From 018d602b21a66c074827d67c1c36d9c97679853a Mon Sep 17 00:00:00 2001
From: =?utf8?q?Paul=20H=C3=A4nsch?= <paul@plutz.net>
Date: Tue, 25 Aug 2020 04:32:33 +0200
Subject: [PATCH] mark end of form submission to prevent incomplete updates

---
 therapies/page.sh           |  1 +
 therapies/update_therapy.sh | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/therapies/page.sh b/therapies/page.sh
index fb86050..bbe845b 100755
--- a/therapies/page.sh
+++ b/therapies/page.sh
@@ -215,6 +215,7 @@ cat <<EOF
   [canvas #canvas .dotmark .ov width="${bg_dim%x*}" height="${bg_dim#*x}" ]
   [input type=hidden #image_serialize name=imagedata value=""]
 
+  [input type=hidden name=formend value=formend]
   [button #savebutton type=submit $(l10n save)]
 ]
 
diff --git a/therapies/update_therapy.sh b/therapies/update_therapy.sh
index bb3901f..70fdea2 100755
--- a/therapies/update_therapy.sh
+++ b/therapies/update_therapy.sh
@@ -28,7 +28,17 @@ if [ "$(POST tid)" != "$(transid "$tpyfile")" ]; then
     printf 'Status: 409 Conflict\r\nContent-Length: 0\r\n\r\n'
     exit 0
   else
-    SET_COOKIE session message="TRANSACTION CONFLICT"
+    SET_COOKIE session message="TRANSACTION_CONFLICT"
+    REDIRECT "/therapies/${tpy%.*}/${tpy#*.}"
+  fi
+fi
+
+if [ "$(POST formend)" != "formend" ]; then
+  if [ "$(POST autosubmit)" = "true" ]; then
+    printf 'Status: 409 Conflict\r\nContent-Length: 0\r\n\r\n'
+    exit 0
+  else
+    SET_COOKIE session message="INCOMPLETE_SUBMIT"
     REDIRECT "/therapies/${tpy%.*}/${tpy#*.}"
   fi
 fi
@@ -36,7 +46,7 @@ fi
 # serialize POST array into file
 for key in $(POST_KEYS); do
   case "$key" in
-    imagedata|tid) : ;;
+    imagedata|tid|formend) : ;;
     session*_date)
       value="$(POST "$key")"
       y=0 mon=0 dom=0
-- 
2.39.2