upgraded to fit new shcgi revision, slightly better input validation, switched to...

[busy] / pages / Subversion.sh

diff --git a/pages/Subversion.sh b/pages/Subversion.sh
index 1e506a8ae1b5d4dd3858c2f2d61ff01cfa623b0c..6f93ff2956737870bf0c440e697ac0569c00f9cb 100755 (executable)
--- a/pages/Subversion.sh
+++ b/pages/Subversion.sh
@@ -17,8 +17,9 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with Busy. If not, see <http://www.gnu.org/licenses/>. 
 
-url="$(echo "$_GET[\"i\"]" |sed -rn '1{s:\t: :g;s:\r::g;s:\\:\\\\:g;s:/+:/:g;p}')"
-rev="$(echo "$_GET[\"r\"]" |sed -rn '1{/^[0-9]+$/p}')"
+url="$(echo "${_GET[i]}" |sed -rn '1{s:\t: :g;s:\r::g;s:\\:\\\\:g;s:/+:/:g;p}')"
+rev="$(echo "${_GET[r]}" |sed -rn '1{/^[0-9]+$/p}')"
+url="${url:-/}"
 
 baseuri=$(sed -rn 's:^svnRepo=(.*)$:\1:p' project.meta)
 lastrev=$(svn info "$baseuri" |sed -rn 's;^Revision: *([0-9]+);\1;p')
@@ -47,7 +48,7 @@ svn_changelog(){
 }
 
 svn_showurl(){
-  if [ -z "$url" -o "${url%/}" != "$url" ]; then
+  if [ "${url%/}" != "$url" ]; then
     # we are showing a directory
     svn propget svn:externals -r "$rev" "${baseuri}/${url}" \
     | sed -rn "s;^([^ ]+) (.+)$;<span class='extern'>\2/</span> [external include from <a href='\1'>\1</a>]<br>;p"