upgraded to fit new shcgi revision, slightly better input validation, switched to...

[busy] / actions / taskmeta.sh

diff --git a/actions/taskmeta.sh b/actions/taskmeta.sh
index 0b2544ddedbc00e2fd0b18af20eff826e48b4dd6..5c5b01dfc486c3e394bb85e301250bfb8c05918d 100755 (executable)
--- a/actions/taskmeta.sh
+++ b/actions/taskmeta.sh
@@ -15,10 +15,10 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with Busy.  If not, see <http://www.gnu.org/licenses/>.
 
-$ACL_CREATETASK || echo "Location: //${HTTP_HOST}/?p=Error&i=noaccess\n\n"
+$ACL_CREATETASK || echo "Location: ?p=Error&i=noaccess\n\n"
 $ACL_CREATETASK || exit 0
 
-info="$_GET[\"i\"]"
+info="${_GET[i]}"
 
 [ -z "$info" ] && info="$(date +%s)_$(apg -M N -a 1 -n 1 -m 3 -x 3)"
 descfile="$_DATA/Tasks/$info.meta"
@@ -28,26 +28,26 @@ commfile="$_DATA/Tasks/$info.comment.$(date +%s)_$(apg -M N -a 1 -n 1 -m 3 -x 3)
 anchor=$(ls $_DATA/Tasks |grep -A2 $info |grep '.meta$' |tail -n1 |cut -d. -f1)
 
 cgi_post
-headline="$_POST[\"headline\"]"
-taskstatus="$_POST[\"status\"]"
-section="$_POST[\"section\"]"
-description="$_POST[\"description\"]"
-comment="$_POST[\"comm\"]"
-[ -n "$_POST[\"cancel\"]" ] && cancel=true
-[ "$_POST[\"submit\"]" = "Robots click here" ] && cancel=true
+headline="${_POST[headline]}"
+taskstatus="${_POST[status]}"
+section="${_POST[section]}"
+description="${_POST[description]}"
+comment="${_POST[comm]}"
+[ -n "${_POST[cancel]}" ] && cancel=true
+[ "${_POST[submit]}" = "Robots click here" ] && cancel=true
 
 if [ -z "$cancel" -a -n "$comment" ]; then
   touch "$_DATA/Tasks/$info"
   echo -e "author=${USER}" > "$commfile"
   echo -e "${comment}" >> "$commfile"
-  echo -n "Location: //${HTTP_HOST}/?p=Tasks&i=$info\n\n"
+  echo -n "Location: ?p=Tasks&i=$info\n\n"
 elif [ -z "$cancel" -a -n "$description" ]; then
   touch "$_DATA/Tasks/$info"
   echo -e "headline=${headline}" > "$descfile"
   echo -e "status=${taskstatus}" >> "$descfile"
   echo -e "section=${section}" >> "$descfile"
   echo -e "${description}" >> "$_DATA/Tasks/$info"
-  echo -n "Location: //${HTTP_HOST}/?p=Tasks#$anchor\n\n"
+  echo -n "Location: ?p=Tasks#$anchor\n\n"
 elif [ -n "$cancel" ]; then
-  echo -n "Location: //${HTTP_HOST}/?p=Tasks#$anchor\n\n"
+  echo -n "Location: ?p=Tasks#$anchor\n\n"
 fi